16
Mar 2023
I feel if this is happening, the same should be done for the README file too.
hardikpandya
Code contributions
Drupal
16
Mar 2023
I agree on the points for README and mixed typehint. I did found a couple of ...
hardikpandya
Code contributions
16
Mar 2023
The README file is missing Table of Contents and Maintainers section.
hardikpandya
Code contributions
16
Mar 2023
In that case, this can be marked RTBC.
hardikpandya
Code contributions
17
Mar 2023
The constants should be preferably declared in an Interface compared to a Class.
hardikpandya
Code contributions
17
Mar 2023
The patch fixes reported phpcs issues. RTBC +1
hardikpandya
Code contributions
17
Mar 2023
The patch fixes reported phpcs issues. RTBC +1
hardikpandya
Code contributions
19
Mar 2023
The last applied patch is not applying.
error: patch failed: src/Plugin/Webfo...
hardikpandya
Code contributions
19
Mar 2023
I have fixed a few more phpcs issues. Attached is the interdiff.
I still see ...
hardikpandya
Code contributions
19
Mar 2023
With Drupal 10 here and reduced support for Drupal 8 going forward, I feel th...
hardikpandya
Code contributions