Contribution Date
Technology
Contribution Project
Contribution Details
Hi Edvaldo Biancarelli,
Below are the things i observed...
podlove_player.install :
1) This is not an application blocker but you should not setup variables inside hook_install() . Drupal by default provides you the ability to use default values inside variable_get() if they are not set.
Refer the variable_get() documentation & the 'default' parameter in it.
2) Suggestion : I guess this message
drupal_set_message($t('Podlove Player Module was successfully installed.
Do not forget to install Podlove Library. See Podlove Help Page in
<a href="@link">Administration > Help > Podlove Player</a>.' ,
array('@link' => '/admin/help/podlove_player')
));should be inside hook_enable().
podlove_player.install
1)You are using system_settings_form(), so no need to setup variables actually in install file, just use the default parameter inside variable_set() in your "#default_value".
podlove_player.module
1) $return = 'Library Podlove Web Player not found'; The string should be inside t() function.
Contribution Issue Link
Contribution Link
Files count
0
Patches count
0