Hi janis,
Below are the some problems i found with the module.
In function we...

Hi janis,

Below are the some problems i found with the module.

• In function webform_validation_no_ccs_webform_validation_validators, Each key/value pair should be seperated by a comma.
• Doc root of hooks should begin with "Implements" & not "Implementation of"
• Variables like $sumTable consist of a capital letter T, which is a bad practice.
• In your JS file, the string "Value must a valid phone number" must end with a full stop.
• Variables like $sumTable consist of a capital letter T, which is a bad practice.
• .info File : Its a good practice to add description in your .info file.
• .info File : Its a good practice to add description in your .info file.
• Docroots overall doesn't look formatted and less descriptive.
• Its a good practice to start all your function names with module names.
• @file is missing.
• Comments should begin with the Capital letters, & must end with a full stop.
• It will be better if you write some granular commenting, it will improve the code readability. For Ex : you have $val = preg_replace("/[^0-9]/", "", $val); , But its hard to understand what its for.
• As an improvement, You could add your JS file inside a js folder in module.