There are a few more instances that can be injected: grep -nri '\Drupal::them...

Contribution Date

Fri, 07/17/2020 - 12:00

Technology

Contribution Project

Contribution Details

There are a few more instances that can be injected:

grep -nri '\Drupal::theme()' core | grep -v .module | grep -vi test | grep -v .api.php | grep -v authorize.php | grep -v .inc
core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php:264:    $regions = \Drupal::theme()->getActiveTheme()->getRegions();
core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php:305:    \Drupal::theme()->alter('page_attachments', $attachments);

Injecting theme manager service in HtmlRenderer.php file and adding Change Record and deprecation error also.
Kindly review a new patch.

Contribution Author

hardikkumarpatel

Contribution Issue Link

Replace non-test usages of \Drupal::theme() with IoC injection

Contribution Link

https://www.drupal.org/project/drupal/issues/3123210#comment-13751132

Files count

2

Patches count

1