Contribution Date
Technology
Contribution Project
Contribution Details
Here are my thoughts on this issue,
1. The patch applies and cleanly with the latest release.
2. This change is nice as $body is accessed as an array in the entire file.
- public $body;
+ public $body = [];
3. Because of this change, I noticed links and bold text got removed from the description of few modules. If we are ok with removing all tags for now (as mentioned in #14 as well) and look for a better alternative to get summary in future, this is an RTBC for me.
- $this->body['summary'] = strip_tags($this->body['summary'], ['p', 'a', 'b', 'i', 'u', 'em', 'strong']);
+ $this->body['summary'] = Html::escape(strip_tags($this->body['summary']));
4. Didn't get any notice anymore on PHP 7.4 and PHP 8. Maybe notice was only in previous PHP versions.
Issue Status
Reviewed and Tested by Community
Contribution Issue Link
Files count
0
Patches count
0