@gskharmujai This will be a nice to have feature. Below is some feedback that...

Contribution Date

Wed, 09/15/2021 - 12:00

Technology

Drupal

Contribution Project

Linkit

Contribution Details

@gskharmujai This will be a nice to have feature. Below is some feedback that I thought of while reviewing this patch.

we should not limit size and max length. These can vary based on user requirements and hence should be kept open.

+++ b/src/Plugin/CKEditorPlugin/Linkit.php
@@ -107,9 +110,38 @@ class Linkit extends CKEditorPluginBase implements CKEditorPluginConfigurableInt
+      '#size' => 2,
+      '#maxlength' => 2,

If we go for type 'number', The validation function won't be required.

+++ b/src/Plugin/CKEditorPlugin/Linkit.php
@@ -107,9 +110,38 @@ class Linkit extends CKEditorPluginBase implements CKEditorPluginConfigurableInt
+      '#type' => 'textfield',

We could change the property 'linkit_AutocompleteLimit' to 'linkit_autoCompleteLimit'

+++ b/js/autocomplete.js
@@ -133,6 +133,13 @@
+        autocomplete.options.minLength = selectedTextFormat.editorSettings.linkit_AutocompleteLimit;

One last thing, The latest release for the module is D9 compatible and has got rid of few deprecations. I think it will be better to make this patch available in the 8.x-4.3 version and also reroll it for the latest release.

Contribution Author

Kunal Kursija

Contribution Issue Link

Add configurable autocomplete min character count

Contribution Link

https://www.drupal.org/project/linkit/issues/3055954#comment-14219211

Files count

0

Patches count

0