Contribution Date
Technology
Contribution Project
Contribution Details
Hi @andeersg,
Below are review comment, please address them
Pareview
I still see below coding standard issue, please fix them
FILE: /Applications/MAMP/htdocs/ezblt/leaflet_layers/src/Form/MapBundleForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
FILE: /Applications/MAMP/htdocs/ezblt/leaflet_layers/src/Form/MapLayerForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
Time: 252ms; Memory: 12MB
Manual Review
- Please add composer to require leaflet module because it's there in the dependency.
- I believe you should use same package name as leaflet which is Geofield, Instead of Custom.
- In leaflet_layers.links.menu.yml file there is one blank line at the top of the file, which you can remove.
- I believe leaflet is third party library, check if you can add license.txt
Contribution Issue Link
Files count
0
Patches count
0