Sorry for the late reply @dewalt...
Just two comments/doubts on the above patch:-
dialog.js is it possible, that an anchor tag could have a
data-external-link-popup-id attribute, valid external domain and a class
.external-link-popup-disabled on it. If this scenario is possible, then we may execute anchor click code, when previously without the patch we would'nt have executed (as it is restricted by the
- On README.txt, could we be more specific about the
or a link class?
Rest of the patch is better, considering that we are covering more scenarios to raise the events...