Contribution Date
Technology
Contribution Project
Contribution Details
Thanks again for all the work. I have a few more comments.
-
+++ b/src/DOComputedFields.php @@ -0,0 +1,74 @@ + $this->service = \Drupal::service('do_username.user_service');
What is `$this->service`? Also, let's give a better name. How about something like `doUserService`?
-
+++ b/src/DOComputedFields.php @@ -0,0 +1,74 @@ + return date('m/d/Y H:i:s', $userInformation->created);
I am thinking lets just return the timestamp or something machine-readable like `date('c', ...)`
-
+++ b/src/Plugin/Field/FieldType/DrupalOrgUsernameItem.php @@ -81,10 +120,10 @@ class DrupalOrgUsernameItem extends FieldItemBase { - '#title' => t('Maximum length'),
I'd rather do this in a separate issue.
Issue Status
Needs work
Contribution Issue Link
Files count
0
Patches count
0