Contribution Date
Technology
Contribution Project
Contribution Details
@yonas.legesse, thanks for your work on the patch. I have a few comments and most of them should be a quick-fix.
-
+++ b/do_username.services.yml @@ -0,0 +1,11 @@ + arguments: ['@do_username.do_client','@cache.data']
Nit: Space after comma
-
+++ b/do_username.services.yml @@ -0,0 +1,11 @@ + ¶ \ No newline at end of file
There is extra whitespace here and no newline
-
+++ b/src/DrupalOrgUserInformationService.php @@ -0,0 +1,64 @@ +class DrupalOrgUserInformationService {
Can we call this class something else? This is rather too long. I am thinking of something like `DOUserInfoRetriever`.
-
+++ b/src/DrupalOrgUserInformationService.php @@ -0,0 +1,64 @@ + * Function to store user information.
The comment is not accurate.
Issue Status
Needs work
Contribution Issue Link
Files count
0
Patches count
0