Contribution Date
Technology
Contribution Project
Contribution Details
Detailed Changes made to the code with the patch #44:-
-
/core/modules/toolbar/css/toolbar.module.css & /core/themes/stable/css/toolbar/toolbar.module.css
- Styles when toolbar fixed are adjusted and moved to a media query
- Because, for narrow devices the toolbar should overlap the main content
- And for wider devices (landscape, tablet, desktops...), the toolbar should push the main content right
-
/core/modules/toolbar/js/models/ToolbarModel.es6.js & /core/modules/toolbar/js/models/ToolbarModel.js
isFixed
&isViewportOverflowConstrained
properties defined for the toolbar in this model- The above properties are only used to decide when to make the toolbar fixed
- Now that the toolbar is fixed for all screen devices, from mobiles to wider screens, we are removing those properties, the javascript dependencies and conditions for fixed toolbar
-
/core/modules/toolbar/js/toolbar.es6.js & /core/modules/toolbar/js/toolbar.js
- In this file, we are 1) triggering the event for change in
isFixed
value and 2) setting the value forisFixed
on toolbar model for standard devices - We will not be requiring it as the toolbar is now always fixed
- In this file, we are 1) triggering the event for change in
-
/core/modules/toolbar/js/toolbar.menu.es6.js & /core/modules/toolbar/js/toolbar.menu.js
- We have a check for setting active tab if toolbar position fixed
- With this patch, we are now removing that check as toolbar is always fixed and
isFixed
property has been removed from the model
-
/core/modules/toolbar/js/views/BodyVisualView.es6.js & /core/modules/toolbar/js/views/BodyVisualView.js
- We are removing the listener and handler function to the change event for
isFixed
andisViewportOverflowConstrained
value to addtoolbar-fixed
class on body element - Instead we are now permanently adding the toolbar fixed class on the body element (updated
isToolbarFixed
method tosetToolbarFixed
)
- We are removing the listener and handler function to the change event for
Basically we are removing all occurrences of isFixed
and isViewportOverflowConstrained
as they are used only to decide when to make toolbar fixed.
Contribution Issue Link
Contribution Link
Files count
0
Patches count
0