Contribution Date
Technology
Contribution Project
Contribution Details
Followings are few observations,
- You have already converted path to lower in device_detector.module LN#122 and again converting coverted string at device_detector.common.inc LN#18
- I'll encourage you to set 'device_detector_node_urls' variable converting all paths to lowecase to avoid doing so while prerocessing html device_detector.common.inc LN#21 & LN#25
-
Please update comment or correct the assignment
// Body class container array. $body_classes = '';
- Please remove
default: break;
from device_detector.module LN#198
- Is it possible to prefix module name to following variables to have a consistency
- is_body_settings_chkd will change to device_detector_is_body_settings_chkd
- is_brwsr_settings_chkd will change to device_detector_is_brwsr_settings_chkd
- is_dsktp_settings_chkd will change to device_detector_is_dsktp_settings_chkd
- is_dvc_settings_chkd will change to device_detector_is_dvc_settings_chkd
Please lemme know if you need more info on above suggested changes.
Contribution Issue Link
Files count
0
Patches count
0