Contribution Date
Technology
Contribution Project
Contribution Details
I have added review comments for the patch posted on #2719611: document special route names.
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { * generate(), generateFromRoute(), and getPathFromRoute() all call this
Please update doc comment with capital letter, like 'Functions generate(), generateFromRoute(), and getPathFromRoute() all call this protected method.'
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { + * String of routing paths.
Please replace this with 'The special string that generates a routing path.' If you think replacement makes more sense.
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { + *
Remove this line, as the following line also continuity of the description of $name parameter.
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { + * This defines the following special routes:
Indentation, (Parameter comment indentation must be 3 spaces)
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { + * This defines the following special routes: + * - <front>: The site's front page. + * - <current>: The current page. + * - <none>: The path that make links relative to the current URL.
Indentation, (Parameter comment indentation must be 3 spaces)
-
+++ b/core/lib/Drupal/Core/Routing/NullGenerator.php @@ -29,6 +29,15 @@ public function __construct(RequestStack $request_stack) { + *
Remove this additional blank line.
Contribution Issue Link
Contribution Link
Files count
0
Patches count
0