Thanks Chaitanya17 for raising the concern and providing the solution. Your s...

Contribution Date

Wed, 01/11/2017 - 12:00

Technology

Drupal

Contribution Project

Image Annotator [Annotorious]

Contribution Details

Thanks Chaitanya17 for raising the concern and providing the solution.

Your solutions were very helpful.
I was not aware of this new way of handling $_POST data.

And in a solution for AnnotationsSaveAction.php, I have used:

$postReq = \Drupal::request()->request->all();
$nid = isset($postReq['nid']) ? $postReq['nid'] : FALSE;
$img_field = isset($postReq['img_field']) ? $postReq['img_field'] : FALSE;
$annotation = isset($postReq['annotation']) ? $postReq['annotation'] : FALSE;

This reduces multiple times calling get() function.

In 8.x-1.1, I have added a new feature and fixed the raised bug. Please use 8.x-1.1.

Issue Status

Needs Review

Contribution Author

abhaysaraf

Contribution Issue Link

replaced $_POST with \Drupal::request()->request->get method

Contribution Link

https://www.drupal.org/project/img_annotator/issues/2842312#comment-11861550

Files count

0

Patches count

0