Thank you. Looks good to me. Can we call it main, as that is the main library...

Contribution Date
Technology
Contribution Project
Contribution Details

Thank you. Looks good to me. Can we call it main, as that is the main library that makes the ajax cart functional. We could have called it replace, but the CSS, that is not playing any part in "replace"-ing, so I think the name main suites here more :) I am open to more suggestions.

Also I was thinking why dc_ajax_add_cart.js is not part of the library. I checked dc_ajax_add_cart.js, and I decided we can optionally attach that JS as per dc_ajax_add_cart_display_popup setting. We are going to add that check inside dc_ajax_add_cart_form_alter(). We can open a new issue for that. Let me know what you think.

Contribution Author
Files count
0
Patches count
0