Contribution Date
Technology
Contribution Project
Contribution Details
Hi Rahul,
I would recommend adding dev branches first, you could start of with a dev branch and can use it to tag your stable versions as you go ahead.
Manual Review of master branch.
Issues I found,
- Create branches (not a issue but something to look into)
- Resolve add "_module_name" to your internal functions so no one overrides them
- http://ventral.org/pareview/httpgitdrupalorgsandboxsrahul071711794git
- Is Ubercart - core (optional) package necessary, it can go in ubercart recurring or ubercart extra if it is be more generic
- Line #32 in .module, initialize
$panes = array();
- Consider a Theme function to wrap HTML around your output so that other modules can do stuff with the HTML if needed, this way your module will provide other modules to override it instead of changing your module's code. You can look into this How to use Drupal 6 theme layer
- Line #96 , consider t()
- Line #127, use format strings instead of " . " in t()
Cheers,
swarad07
Contribution Issue Link
Contribution Link
Files count
0
Patches count
0