From experience with #2847914: Attempts to create an user even if it already ...

Contribution Date
Technology
Contribution Project
Contribution Details

From experience with #2847914: Attempts to create an user even if it already exists, I'd suggest to differentiate different results of this new method. There might be a case when the user is present but cannot login (if the user is blocked, for example). And then there is the regular case of the user does not exist. The related issue exists because we do not differentiate between these two scenarios. The calling code should know why exactly the login failed and then if it was because of missing user, only then attempt to create the user.

Alternatively, this entire flow seems common among all such modules. We could have a method called something like authenticateOrCreateUser() that does the entire job.

Issue Status
Active
Contribution Author
Files count
0
Patches count
0