Contribution Date
Technology
Contribution Project
Contribution Details
There is still a master branch, remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732.
I haven't played much with this module but some quick manual review.
Manual Review
- It would be great if you could mention some example incorrect usage of this module which can realy harm site security, in Project description or somewhere in README.txt file.
- .info file description and Project description in sandbox is different. In Project description it is : "Allows an developer to log in as user #1 with user accounts from a separate authentication source, such as LDAP. Can also be used without LDAP to login" and in .info file its : "Allows developers to login via LDAP as user #1". I think in .info file should have description similar to this text "Allows developers to login via separate authentication source such as LDAP or other authentication as user #1"
- In .install file line no 14 looks overhead. Get rid of $t = get_t(); line.
- In .module file, Line no 12 : Remove $items = array(); no need of defining $items. $items will be deined and initialized in next line.
- You may need to add validate function for developer_authentication_form in .module file
Regards,
Chintan Vyas.
Contribution Issue Link
Files count
0
Patches count
0