Hi,
Had a quick look on this. Below is my review...
1) No pareview errors &am...

Contribution Date
Technology
Contribution Details

Hi,

Had a quick look on this. Below is my review...

1) No pareview errors & No Coder Module errors.

2) DB_TRACK_REPORT.ADMIN.INC :
You have listed the theme table which is ok for small data - Say 20 - 30 Entries on page, But in case of large number of entries - the query execution and page load will be more.
This is not good from user perspective and also from system health persepctive.
So, i think you should go for theme("pager") by limiting the number of records on page to minimum value.

3) DB_TRACK_SETTINGS.ADMIN.INC :
You have created a simple textarea for URL / LINE.
But you are directly saving data inside the variable and not validating anything.
For Example: was able to enter this inside the fieldset...

a) "!@#$%^&*&^&((*()JNJKLM:"}".
b) db_query("SELECT nid, title FROM {node}");

I doubt if that should happen from security point of view.

Contribution Author
Files count
0
Patches count
0