Adding Change Record and deprecation error for UserLoginBlock file. Kindly re...

Contribution Date

Fri, 07/17/2020 - 12:00

Technology

Drupal

Contribution Project

Drupal core

Contribution Details

Adding Change Record and deprecation error for UserLoginBlock file. Kindly review a new patch.

Checking remaining replacement files.

grep -nri '\Drupal::formBuilder()' core | grep -v .module | grep -vi test | grep -v .api.php | grep -v authorize.php | grep -v .inc
core/lib/Drupal/Core/Form/FormCache.php:180:    // \Drupal::formBuilder()->getCache() and \Drupal::formBuilder()->setCache()
core/lib/Drupal/Core/Form/FormBuilderInterface.php:149:   * \Drupal::formBuilder()->submitForm('user_register_form', $form_state);
core/lib/Drupal/Core/Form/FormState.php:50:   *     automatically loaded by \Drupal::formBuilder()->getCache(). By default
core/lib/Drupal/Core/Form/FormState.php:1202:    // \Drupal::formBuilder()->doBuildForm() collects all button elements in a
core/lib/Drupal/Core/Config/Entity/DraggableListBuilder.php:174:      $this->formBuilder = \Drupal::formBuilder();
core/lib/Drupal/Core/Render/Element/RenderElement.php:138:    // \Drupal::formBuilder()->doBuildForm().

All calls are commented except below one.

core/lib/Drupal/Core/Config/Entity/DraggableListBuilder.php:174:      $this->formBuilder = \Drupal::formBuilder();

Not sure why it was done this way and can we replace this with injected service or not.

@msuthars, for ActionListBuilder i am not sure about this we can inject service in it or not.

Contribution Author

hardikkumarpatel

Contribution Issue Link

Replace non-test usages of \Drupal::formBuilder() with IoC injection

Contribution Link

https://www.drupal.org/project/drupal/issues/3123209#comment-13751202

Files count

0

Patches count

0