@nikitagupta thanks for working on this issues , but we need to inject Reques...

Contribution Date

Thu, 08/27/2020 - 12:00

Technology

Contribution Project

Contribution Details

@nikitagupta thanks for working on this issues , but we need to inject Request(\Drupal::request()) service before replacements as we have done in core/lib/Drupal/Core/Mail/MailManager.php file.

Solving failed test cases of #10 , if we want do changes for only non-test file then this test cases will always gone be fail.

core/lib/Drupal/Core/Render/Element/RenderElement.php:349:        $settings['options']['query'] += \Drupal::request()->query->all();

FOr this file \Drupal::request() call is under static function so this looks ok to me.

core/lib/Drupal/Core/Database/Query/TableSortExtender.php:37:    $context = TableSort::getContextFromRequest($header, \Drupal::request());
core/lib/Drupal/Core/Entity/Query/QueryBase.php:333:    $order = TableSort::getOrder($headers, \Drupal::request());
core/lib/Drupal/Core/Entity/Query/QueryBase.php:334:    $direction = TableSort::getSort($headers, \Drupal::request());
core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php:94:    $request = \Drupal::request();

For this files can anyone suggest good way to inject \Drupal::request() call.

Contribution Author

hardikkumarpatel

Contribution Issue Link

Replace non-test usages of \Drupal::request() with IoC injection

Contribution Link

https://www.drupal.org/project/drupal/issues/3123224#comment-13802737

Files count

2

Patches count

1