Contribution Date
Technology
Contribution Project
Contribution Details
Updated the Issue summary with steps to replicate.
Reviewed the Patch provided in #3
Thanks @ cadila
- The patch applies clean.
- The proposed logic works as intended.
Rerolled the patch with the changes.
Removed the unused/ additional probably duplicated from Role based from
$roles = Role::loadMultiple();
$optionarray[] = '';
foreach ($roles as $rolekey => $roleval) {
if ($rolekey != 'administrator' && $rolekey != 'authenticated' && $rolekey != 'anonymous') {
$optionsarray[$rolekey] = $roleval->label();
}
}
Not specific with this issue, part of PHPCS
+ /** @var \Drupal\user\UserInterface $user */
Added a new issue to track the PHPCS fixes. So that all the PHPCS issues can be tracked together.
Fix phpcs --standard=Drupal and phpcs --standard=DrupalPractice for the Force Users Logout module
Issue Status
Needs Review
Contribution Issue Link
Files count
5
Patches count
1