Contribution Date
Technology
Contribution Project
Contribution Details
+++ b/core/lib/Drupal/Core/Access/CsrfTokenGenerator.php
@@ -90,6 +90,7 @@ public function validate($token, $value = '') {
+ @trigger_error('Passing non-string value to ' . __METHOD__ . '() is deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Clean-up calling code. See https://www.drupal.org/node/3156880', E_USER_DEPRECATED);
Is this deprecation message a documented template? I feel that "Clean-up calling code" is unnecessary. On one hand, it's not very descriptive and I was actually confused reading it. It took me a moment to see what it meant. And then I realised that it is kinda obvious that deprecation means that we have to stop doing that.
Also, "Clean-up" could have other connotations but let's not go into that here.
Secondly, I think we should say which parameter does not accept non-string values anymore.
Contribution Issue Link
Contribution Link
Files count
0
Patches count
0