Contribution Date
Technology
Contribution Project
Contribution Details
Hi @sugandhkhanna2,
This module is not working for me. I am not able to find "node:title" and whenever i am trying to click on submit button it throws an error for me(Kindly check the screenshot for reference).
Manual Review:
- Whenever i try to access /nodename/autocomplete/multiple page i get a blank page. please let me know if i am missing something
- It is a good practice to add hook_help in .module file
- I would suggest you to add configure in .info.yml file
ANSBlock.php
37
/**
* {@inheritdoc}
*/
public function validateForm(array &$form, FormStateInterface $form_state) {
}
I would recommend no need to write this function untill you don't want to do some validation from your end.
- Try to use dependency injection (3rd screenshot is related to it.)
AutocompleteQueryHandler.php
27
$nids = \Drupal::entityQuery('node')
ANSBlock.php
22
$builtForm = \Drupal::formBuilder()->getForm('Drupal\autocomplete_node_search\Form\AutocompleteNodeSearch');
Recommendation: 'formBuilder' service should be injected.
Contribution Issue Link
Files count
0
Patches count
0