Contribution Date
Technology
Contribution Project
Contribution Details
The patch applies cleanly, however, the drupal-check report has 1 error:
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ -----------------------------------------------------------------------
Line src/SingleLanguageNegotiationUrl.php
------ -----------------------------------------------------------------------
132 PHPDoc tag @param has invalid value ($path
Path to check.): Unexpected token "$path", expected type at offset 87
------ -----------------------------------------------------------------------
also, some Drupal coding standard issues reported by PHPCS:
FILE: single_language_url_prefix.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------
FILE: src/Form/SettingsForm.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------
9 | ERROR | [x] Doc comment short description must end with a full stop
35 | ERROR | [x] Short array syntax must be used to define arrays
47 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
FILE: src/SingleLanguageNegotiationUrl.php
---------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------
76 | ERROR | [x] Space before opening parenthesis of function call prohibited
99 | ERROR | [x] Multi-line function declarations must define one parameter per line
126 | ERROR | [ ] Missing parameter type
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------
Contribution Issue Link
Files count
0
Patches count
0