Contribution Date
Technology
Contribution Project
Contribution Details
@monojnath, please address preview.sh comments.
Following is being copied from http://pareview.sh/pareview/httpgitdrupalorgsandboxnathmonoj20142523140git
Review of the 7.x-1.x branch (commit c8e882e):
- Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
FILE: ...w/drupal-7-pareview/pareview_temp/includes/device_detector.common.inc
---------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Inline comments must start with a capital letter
73 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, or question marks
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
84 | ERROR | [x] Inline comments must start with a capital letter
84 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, or question marks
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: ...review/pareview_temp/includes/device_detector.admin.config.device.inc
---------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
65 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
65 | ERROR | [x] There should be no white space before a closing ")"
71 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
71 | ERROR | [x] There should be no white space before a closing ")"
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: ...eview/pareview_temp/includes/device_detector.admin.config.browser.inc
---------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
286 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
286 | ERROR | [x] There should be no white space before a closing ")"
311 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
311 | ERROR | [x] There should be no white space before a closing ")"
326 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
326 | ERROR | [x] There should be no white space before a closing ")"
336 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
336 | ERROR | [x] There should be no white space before a closing ")"
346 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
346 | ERROR | [x] There should be no white space before a closing ")"
356 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
356 | ERROR | [x] There should be no white space before a closing ")"
366 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found
366 | ERROR | [x] There should be no white space before a closing ")"
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
Time: 674ms; Memory: 16.75Mb
Source: http://pareview.sh/ - PAReview.sh online service
Contribution Issue Link
Files count
0
Patches count
0