Embedding tags within string is not a good practice right? +++ b/core/modules...

Contribution Date

Mon, 02/09/2015 - 12:00

Technology

Contribution Project

Contribution Details

Embedding tags within string is not a good practice right?

+++ b/core/modules/node/src/NodeTranslationHandler.php
@@ -68,7 +69,10 @@ public function entityFormAlter(array &$form, FormStateInterface $form_state, En
-    return t('<em>Edit @type</em> @title', array('@type' => $type_name, '@title' => $entity->label()));
+    return String::format('%edit @title', array(
+      '%edit' => t('Edit @type', array('@type' => $type_name)),
+      '@title' => $entity->label(),
+    ));

That is why I have made such changes here. Otherwise, there is no problem.

Contribution Author

subhojitpaul

Contribution Issue Link

Page title escaped with HTML markup when editing content translation

Contribution Link

https://www.drupal.org/project/drupal/issues/2394951#comment-9602489

Files count

0

Patches count

0