Re #47:
When an order is parked we need to create a new order.
I checked in Drupal 7. There is no new order created after parking an order. The state is changed. The same is happening in Drupal 8.
I'm not sure that we need this
if
I am sure I am missing something obvious here. The Park Order button is not supposed to appear if the order is already parked.
It's super weird to list parked orders at the top of the order screen. How did it work before?
Shawn decided to put this at the top. See #18
I think parking an order should create a new current order
I checked the Drupal 7 code. I saw that there the Commerce Order's status is just changed. I do not know whether it is supposed to do it differently in Drupal 8.
Needs '#limit_validation_errors' => [] or we need validation since parking an empty order makes very little sense.
Yeah. Makes sense.
Re #49:
I don't think this is necessary. PosForm::parkOrder() can set the state and save it.
I was trying to expose these as APIs. So that in future if there is a need to check whether CurrentOrder is parked or not, or needs to be parked. Then we can do that from the service itself, rather than calling it from a function.
Should this park an empty order?
Yes. We should put a check here.