+++ b/core/modules/migrate_drupal/src/Plugin/migrate/cckfield/CckFieldPlugin...

Contribution Date
Technology
Contribution Project
Contribution Details
  1. +++ b/core/modules/migrate_drupal/src/Plugin/migrate/cckfield/CckFieldPluginBase.php @@ -1,83 +1,17 @@ -namespace Drupal\migrate_drupal\Plugin\migrate\cckfield; +namespace Drupal\migrate_drupal\Plugin\migrate\field;

    The namespace shouldn't really change here. Apart from breaking BC, it also makes this class impossible to find as the directory hasn't changed.

  2. +++ b/core/modules/migrate_drupal/src/Plugin/migrate/cckfield/CckFieldPluginBase.php @@ -1,83 +1,17 @@ +abstract class CckFieldPluginBase extends FieldPluginBase { }

    As per standards, this could all be on one line.

Another thing I realized is that since the migrations now use the newer classes, which use the newer annotations, and so on, the tests really don't check for old classes anymore. I don't really care too much about that though.

Contribution Author
Files count
0
Patches count
0